ipc4: logging: fix builds with mtrace and probes both disabled #8222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kv2019i
requested review from
lgirdwood,
mmaka1,
lbetlej and
dbaluta
as code owners
plbossart
approved these changes
Sep 18, 2023
aiChaoSONG
approved these changes
Sep 19, 2023
btian1
approved these changes
Sep 19, 2023
abonislawski
approved these changes
Sep 19, 2023
If both SOF_PROBES and MTRACE logging backends are disabled at build time, IPC4 build failed due to undefined ipc4_logging_enable_logs(). Fixes a bug in commit 1721f70 ("logging: add logging through probes"). Signed-off-by: Kai Vehmanen <[email protected]>
kv2019i
force-pushed
the
202309-logging-probe-fix-regression
branch
from
72f87b3 to
c8d3311
Compare
lyakh
approved these changes
Sep 20, 2023
|
Amazing , all tests pass! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If both SOF_PROBES and MTRACE logging backends are disabled at build time, IPC4 build failed due to undefined ipc4_logging_enable_logs(). Fixes a bug in commit 1721f70 ("logging: add logging through probes").